Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sile 0.9.3 #1039

Closed
wants to merge 1 commit into from
Closed

sile 0.9.3 #1039

wants to merge 1 commit into from

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented May 10, 2016 •
edited
Loading

add a test
disable bottling due to LuaRocks requirements

@ilovezfs ilovezfs mentioned this pull request May 10, 2016
Closed
53 tasks
MikeMcQuaid
MikeMcQuaid reviewed May 10, 2016
View reviewed changes
Formula/sile.rb
@@ -11,6 +11,8 @@ class Sile < Formula
depends_on "libtool" => :build
end

bottle :disable, "LuaRocks requirements preclude bottling"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭 Should see if we can vendor these at some point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah: Homebrew/legacy-homebrew#42273

@MikeMcQuaid
Copy link
Member

👍

@ilovezfs ilovezfs closed this in 2177b86 May 10, 2016
@ilovezfs ilovezfs deleted the sile-0.9.3 branch June 3, 2016 10:58
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilovezfs @MikeMcQuaid